SamuriHL
UHD Guru
- Joined
- Jan 28, 2007
- Messages
- 15,034
- Likes
- 2,530
Nice.
That's a plus. lol
It was always supposed to do that. And did in my testing but there were some weird scenarios where it didn't work as planned.
Right, it'll only update the storage of your name if it's a valid change and only once you leave that field. I.E. it won't update anything while you're typing it, but once you click out of that field, if it's valid, it'll update it. If it's not valid, i.e. you erase it, it won't update the stored value. This, too, was how it was always meant to work and did in my testing prior to this release. However, as with everything else, I found some nasty bugs in that code so it probably didn't work nearly as well as was intended. It will now.
Yea, that's fine. Likely in the next few days unless we see some kind of showstopping issue. There could still be some whacky edge cases kicking around. These changes I made initially introduced a couple new bugs that I quickly squashed before releasing it, found in my own testing with the report I made earlier. All those modes made the code far less clean than I would have liked and that's what I think caused the issues we were seeing with blank names in reports. It shouldn't happen, but there were a lot of different ways to enable things in the scanner prior to these fixes that should not have been allowed. Now everything goes through one entry point for enabling/disabling scanner features. So we'll see and if it's good we'll set it to required so we can nuke those blank name reports.
