[BUG?] - Subtitle overwritten

Discussion in 'AnyStream' started by Ch3vr0n, Oct 20, 2020.

  1. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    I'm not sure if this behavior was fixed earlier. While testing my new britbox amazon prime video trial addon (i'll know in a week if the card from usunlocked worked :p if it gets charged) i had a go at grabbing classic doctor who. Some of the titles i encountered had 2 close-captioned english subtitle tracks.

    The problem with that is when in SRT mode (don't know if other modes are affected too), is that 1 cc track replaces the other. The tracks were labelled as

    English (US) [CC] and English (UK) [CC]. Perhaps it's an idea in such a case to add those to the subtitle file to prevent replacing.

    eg: titlename.en.us.cc.srt and titlename.en.uk.cc.srt or any variation. This technically applies to my subtitle tracks for my native dutch (belgium) and dutch (netherlands). Dutch Belgium could be labelled as .nl and Dutch Netherlands as .dut (both btw are accepted by Plex for example as valid dutch language tags)
     
  2. testiles

    testiles Well-Known Member

    No, it's been this way all along with external Subtitles.


    I've tested with every release and if the same language, one overlays the other.



    T
     
  3. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    Well @Prospere can this be fixed like above?
     
  4. libris

    libris Member

    Same here.
     
  5. testiles

    testiles Well-Known Member

    The same goes for English CC and English forced.

    Or any two English Subtitles.

    They all get the name <title>. en.srt.

    Perhaps if, as you said (and has been proposed before) the filename is closer to what's displayed in the Selection box, duplicate names and overwriting could be avoided.



    T
     
  6. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    probably isn't limited to english and dutch. I'd be willing to bet it applies to ANY "duplicate" language. Such as "Spanish (Spain)" and "Spanish (Portugese)" etc too.
     
  7. testiles

    testiles Well-Known Member

    I'm sure it's a general problem of the same file name being generated and causing overwriting, for any 2 Subtitles of the same basic language, since the language is all that's used to qualify the filename.


    Correction: It worked briefly - in 1.0.1.0.



    T
     
  8. testiles

    testiles Well-Known Member

    I just did a quick check.

    Couldn't find a movie with multiple English subs right away, but downloaded an Expanse episode from Amazon where there are multiple Spanish subs...


    So, when I selected "Espanol (Espana)" and "Espanol (Espana) forced narrative", I got two SRT files, the difference being "forced" was part of the filename of one of them.

    So maybe "forced" sub overwriting is fixed.


    But when I selected "Espanol (Espana)" and "Espanol (Latinoamerica)", only one SRT file was created, ending is ...es.srt.

    And that's the issue Ch3vr0n is alluding to.

    Same main language but different flavors, one overwrites the other.


    T
     
  9. Prospere

    Prospere RedFox Development Team

    Can't be. At least regular and forced should have distinct names.
     
  10. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    I'll have to find a title with cc and non-cc but in this case (classic doctor who) both were cc english (just one for US, the other Uk) and one replaced the other srt. I have no use for embedded subtitles.

    Sent from my Pixel 3 XL using Tapatalk
     
  11. albino

    albino Active Member

    Maybe they can fix it so they're downloaded with the full language code of en-us and en-gb instead of just en or eng. The same goes for other languages like Spanish which will often have es-es for Spain and then something like es-mx for Mexico.
     
  12. testiles

    testiles Well-Known Member

    Yes, you're right, of course Prospere. My bad!

    I found that out and tried to comment on it in post #8, but probably wasn't clear.


    The forced is definitely creating it's own SRT, even if another sub of the same language is requested.



    T
     
  13. Prospere

    Prospere RedFox Development Team

    Ah, I may have missed it (late hour). But en-us/en-gb may pose a problem. I'll look into what @albino proposes.
     
    albino and Aeneas72 like this.
  14. testiles

    testiles Well-Known Member

    Yes, it's a good suggestion! :=)


    T
     
  15. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    To be fair, I Suggested that first in op :p

    Sent from my Pixel 3 XL using Tapatalk
     
  16. testiles

    testiles Well-Known Member

    Oh, yeeeeah. :)


    But I think he's saying without the ".cc".

    Just <title>.en.uk.srt, for example.


    But same concept, yeah.



    T
     
  17. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    Yeah but it would have to work for cc too or we'd be back to square one.

    Sent from my Pixel 3 XL using Tapatalk
     
  18. Prospere

    Prospere RedFox Development Team

    As I said - it was a late hour ;)

    I will see whether I can push a fix into the upcoming release (should really happen today).
     
    Aeneas72 likes this.
  19. Ch3vr0n

    Ch3vr0n Translator NL & Mod

    Well........... Did you? >.<

    Sent from my Pixel 3 XL using Tapatalk
     
  20. Prospere

    Prospere RedFox Development Team